DR2 2042 Add Remove path substitution button#520
Merged
Conversation
techncl
changed the title
sparkhi
reviewed
Jan 16, 2025
| tblPathSubstitutions.popupMenu(popupMenu) | ||
|
|
||
| private val spTblPathSubstitutions = new ScrollPane(tblPathSubstitutions) | ||
| private val btnRemovePathSubstitution = new Button("Remove Path Substitution...") |
Contributor
There was a problem hiding this comment.
Please remove the ... from the text. The ellipsis in UI is a cue to user that there will be more input needed before the action is performed. In case of Removal, the action is performed as soon as the button is clicked so it should not have the ellipsis
I know, this rule is violated elsewhere in the UI (e.g. "save" button, which technically works like "save as...") but I think for new button addition we should do it correctly
sparkhi
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.